feat(ticket-048): publish github event acquisition adapter without env fallbacks - #66

Validation rejected:

• Patch may contain a secret: token=

Deterministic Validator approval for exact head 33d62df339d411ed25e2f5554676233cf1ebc097.

Ticket: ticket-048
Correlation ID: todo2code-pr-66-ticket-048
Model: openrouter/z-ai/glm-5.2
Reviewed diff chunks: 7
Advisory LLM verdict: BLOCK
Advisory summary: Reviewed all 7 diff chunk(s). This chunk adds documentation, ticket records, and historical artifacts for ticket-047 and ticket-048. The diff content is documentation and metadata only (README, changelog, logs, intent, TODO, TICKETS index, EVENT_LOG_DSL docs). No executable source code changes are visible in this chunk. The PR body describes removing process.env fallbacks from scripts/github-event-log.mjs, but that script's actual code is not in this chunk. The test_results_data reports one failed check ('Live OpenRouter contract (opt-in): FAIL'), which mandates a non-APPROVE verdict. However, since this is a documentation-only chunk, the failure likely originates from code/test chunks reviewed separately. | This chunk contains ticket-047 governance scaffold files (ai-codex.md, changelog.md, intent.json, preprompt.md) and the start of ticket-048's README. The intent.json declares a well-scoped adapter with clear allowed/forbidden paths and validation criteria. The historical record is transparent about prior publication failures. However, the test_results_data contains a failing check ('Live OpenRouter contract (opt-in): FAIL'), which per validation rules prevents APPROVAL. The visible code is documentation/metadata only; no executable code is shown in this chunk. | This chunk contains ticket-048 documentation, agent logs, and participant records. The PR republishes ticket-047's GitHub event-log adapter by removing process.env fallbacks and making CLI flags required. Documentation is thorough and the security boundary improvement (removing ambient environment reads) is sound. However, test_results_data shows one failing check ('Live OpenRouter contract (opt-in): FAIL') which blocks approval. | A required check in test_results_data is failing: 'Live OpenRouter contract (opt-in): FAIL'. Per validation rules, a failed check precludes APPROVE and mandates BLOCK. The diff chunk shows the script entrypoint (scripts/github-event-log.mjs) beginning cleanly with no process.env reads, CLI-only flag parsing, and strict input validation, which is consistent with the PR's stated security boundary; however, the visible code is only a partial fragment of the script and cannot be fully assessed for completeness. | Live OpenRouter contract check failed. PR introduces GitHub event-log adapter code with input validation, but untrusted test results contain a failing check requiring block per protocol. | This diff chunk adds GitHub event-to-event-log mapping logic for pull_request_review and workflow_run events, plus test fixtures and a test file import. The code is largely well-structured, but a failed CI check (Live OpenRouter contract) mandates REQUEST_CHANGES. Additionally, the test file diff shown only adds an import and path constants with no visible new test cases in this chunk, and the workflow_run_with_bad_timestamp fixture has head_sha at the top level rather than inside workflow_run, which may cause validation errors depending on asSha's null tolerance. | A failed check is present in test_results_data ('Live OpenRouter contract (opt-in): FAIL'), which mandates BLOCK per review rules. No security finding is inferable from this chunk alone; the code shown is test-only and validates fail-closed behavior for ambient environment handling, unsupported review states, and payload leak prevention. The tests themselves appear well-structured for the visible chunk.
Advisory findings: test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Per validation rules, this prevents APPROVE regardless of which chunk triggered it.; test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Per validation rules, APPROVE is not permitted when any check has failed.; Live OpenRouter contract (opt-in): FAIL — a failing check in test_results_data prohibits approval per validation rules; test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. No APPROVE is permitted while any check is failing.; Test results include 'Live OpenRouter contract (opt-in): FAIL'; protocol prohibits APPROVE when any check fails.; test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Per review policy, APPROVE is prohibited when any check has failed.; test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Rules require never APPROVE when a failed check exists, and BLOCK applies when a failed check is present.; Removal of process.env.GITHUB_EVENT_PATH and process.env.GITHUB_REPOSITORY fallbacks is a positive security change — a bounded acquisition boundary should not silently inherit ambient process state. No new secret exposure or vulnerability introduced in this chunk.; Adapter claims to remove both process.env fallbacks (GITHUB_EVENT_PATH, GITHUB_REPOSITORY); the visible code confirms no process.env imports or reads in the shown portion. The remaining ~437 lines must confirm no ambient-environment reads, no eval/exec of payload data, and no path traversal via --event-path/--output before full attestation.; createPushEvents asActor fallback of 'github' allows a default actor identity when no pusher/sender is present; ensure downstream consumers treat 'github:github' as a system/anonymous actor and do not elevate trust.; canonicalEvidence uses stableStringify on raw payload-derived objects; verify no secrets (tokens, webhooks secrets) are present in retained evidence payloads.; Fixture 'workflow_run_secret' deliberately includes a 'secret' field and nested 'raw_payload' with query/headers to verify canonicalEvidence strips sensitive data. This is a positive security test; confirm canonicalEvidence is allowlist-based rather than denylist-based so unknown sensitive fields are excluded.
The LLM output above is advisory and was not used as the approval trust root.
Merge was not requested or performed.

Decision record (recomputable)

DECISION D-048-0902
TICKET ticket-048
HEAD_SHA 33d62df339d411ed25e2f5554676233cf1ebc097
CORRELATION_ID todo2code-pr-66-ticket-048
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["koru / code-review=PASS","Live OpenRouter contract (opt-in)=FAIL","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "env/request"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "BLOCK" MODEL "openrouter/z-ai/glm-5.2"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

Deterministic Validator approval for exact head 071b707c342b8c67e373fc1899578c21d90a0c02.

Ticket: ticket-048
Correlation ID: todo2code-pr-66-ticket-048
Model: openrouter/z-ai/glm-5.2
Reviewed diff chunks: 7
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 7 diff chunk(s). This chunk adds documentation, ticket metadata, and historical records for the ticket-047/ticket-048 GitHub event acquisition adapter. The docs clearly describe a fail-closed, no-process.env boundary. However, the provided test results include one failing check (Live OpenRouter contract), which prohibits approval. Additionally, only documentation and ticket-metadata files are visible in this chunk; the actual script and test code changes are in other chunks and cannot be assessed here. | This chunk contains governance documentation, intent.json, changelog, and participant records for ticket-047 and ticket-048. The PR republishes ticket-047's GitHub event log adapter after removing process.env fallbacks that caused the .env.example governance blocker. The intent.json declares proper allowedPaths/forbiddenPaths, budget constraints, and validation criteria. The documentation clearly explains why the prior attempt failed (GOV-INTENT-003, GOV-TICKET-001, unownable .env.example path) and how the structural fix addresses each blocker. No security issues found in the visible code. Test results show verify PASS, Koru code-review PASS, and Java adapter PASS; the Live OpenRouter contract FAIL is an opt-in check outside core verification. | Chunk 3 of 7 contains ticket-048 project documentation, agent logs, and participant records. The changes remove process.env fallbacks from the GitHub event log adapter, require explicit flags, and carry forward ticket-047's historical record. The PR body and logs are internally consistent. However, the test_results_data includes a failing check (Live OpenRouter contract: FAIL), which mandates REQUEST_CHANGES per protocol. No security issues or code defects are visible in this documentation-only chunk. | This chunk introduces the ticket-048 governance scaffold, the github-event-log.mjs adapter script (beginning), and supporting documentation. The diff is mostly governance metadata, decision logs, changelogs, and the initial portion of the adapter script. A blocking concern is the test results data showing a failed check ('Live OpenRouter contract (opt-in): FAIL'), which requires changes before approval. The adapter script shown here removes process.env fallbacks (a stated security improvement), but the full script is not visible in this chunk to confirm complete removal. | Reviewed chunk 5 of the github-event-log.mjs adapter. It removes process.env fallbacks and validates input via flags/payload only. The parser handles --help, odd-length args, duplicate options, and missing values. However, a clear truncation/incomplete function boundary is visible at createPullRequestReviewEvents, making this chunk impossible to validate for completeness. | The chunk shows GitHub event builders for pull_request_review and workflow_run, plus the main() entry point and test fixtures. The code removes process.env fallbacks (per PR intent) and validates inputs defensively. However, there are correctness concerns in the workflow_run timestamp handling and a potential correlation-id fallback issue, and one test suite is reported as failing. | This chunk adds comprehensive tests for the GitHub event collector adapter, covering push payload mapping, review event trust classification, fail-closed behavior for unsupported review states, evidence allowlisting/leak prevention, and ambient environment rejection. The tests are well-structured and assert security-relevant properties including no process.env fallback, no payload field leakage, and fail-closed on missing required inputs. However, the test results data shows a failing check ('Live OpenRouter contract (opt-in): FAIL') which precludes approval.
Advisory findings: test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. A failing check must be resolved or shown to be opt-in/non-blocking with evidence before approval.; test_results_data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Regardless of its opt-in nature, the protocol prohibits APPROVE when any check in test_results_data has failed.; Test results data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Per policy, this cannot be approved until all checks pass.; createPullRequestReviewEvents function is cut off mid-body after the actor assignment; cannot assess whether event creation and validation are correct for review events. Given the instruction to treat this as a complete chunk, I report this as a visible structural gap: the chunk ends at a statement that does not terminate the function, so semantic correctness of review-event handling cannot be confirmed.; Live OpenRouter contract (opt-in): FAIL — test_results_data contains a failed check; cannot APPROVE per rules.; In createWorkflowRunEvents, the workflow_run_with_bad_timestamp fixture sets updated_at to '2026-08-05 08:13:00' (space separator) while created_at is ISO '2026-08-05T08:13:30Z'. The builder uses updated_at first; if asTimestamp rejects the space-separated format, the fixture path may be the intended error test, but there is no head_sha validation handling shown for workflow_run_with_bad_timestamp (it omits workflow_run.head_sha and sets a top-level head_sha that the builder does not read via that path). This may cause an unexpected validation error rather than the intended timestamp rejection.; In main(), correlationFallback reads payload.review?.id but createPullRequestReviewEvents accesses review at payload.review — consistent. However correlationFallback does not include payload.pull_request?.number or a review-specific fallback from payload.review?.id before pull_request?.id; ordering means a PR event without an id may still resolve to sender.id, which is a weak correlation source for push events (payload.pusher lacks id in fixtures). Verify asString(options.correlationId, correlationFallback) throws when fallback is empty for push events with no sender.id.; Test results data contains a failed check: 'Live OpenRouter contract (opt-in): FAIL'. Per policy, APPROVE cannot be issued when any check has failed.; No security findings. The removal of process.env fallbacks is a security improvement: it prevents a bounded acquisition boundary from silently inheriting ambient process state, which could otherwise allow unexpected environment-driven behavior.; No process.env reads present in the visible code, consistent with the stated boundary fix. Fixtures include a workflow_run_secret payload with 'secret' and 'raw_payload' fields; verify that canonicalEvidence only serializes whitelisted fields (not visible in this chunk) so secret/raw_payload never appear in output. The fixture exists to assert this, which is appropriate, but the guarantee depends on canonicalEvidence behavior outside this chunk.
The LLM output above is advisory and was not used as the approval trust root.
Merge was not requested or performed.

Decision record (recomputable)

DECISION D-048-2831
TICKET ticket-048
HEAD_SHA 071b707c342b8c67e373fc1899578c21d90a0c02
CORRELATION_ID todo2code-pr-66-ticket-048
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["koru / code-review=PASS","Live OpenRouter contract (opt-in)=FAIL","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "env/request"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openrouter/z-ai/glm-5.2"
ASSERT VERDICT_AUTHORITY != "ADVISORY"